yangshangqing95 commented on code in PR #17440:
URL: https://github.com/apache/iceberg/pull/17440#discussion_r3693524925
##########
core/src/main/java/org/apache/iceberg/BaseEntriesTable.java:
##########
@@ -203,7 +203,7 @@ public <T> Boolean gtEq(BoundReference<T> ref, Literal<T>
lit) {
public <T> Boolean eq(BoundReference<T> ref, Literal<T> lit) {
if (fileContent(ref)) {
Literal<Integer> intLit = lit.to(Types.IntegerType.get());
- if (!contentMatch(intLit.value())) {
+ if (!mayContainFileContent(intLit.value())) {
Review Comment:
Good point. The current implementation already prunes both data and delete
manifests for out of range content values because mayContainFileContent returns
false for those literals. I added coverage for equal("data_file.content", 3)
and in("data_file.content", 3, 4) for both entries and all_entries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
