szehon-ho commented on code in PR #17318: URL: https://github.com/apache/iceberg/pull/17318#discussion_r3694470569
########## format/spec.md: ########## @@ -2085,7 +2085,7 @@ Snapshot summary can include metrics fields to track numeric stats of the snapsh | **`total-delete-files`** | Total number of live positional/equality delete files and deletion vectors in the snapshot | | **`added-records`** | Number of records added in the snapshot | | **`deleted-records`** | Number of records deleted in the snapshot | -| **`total-records`** | Total number of records in the snapshot | +| **`total-records`** | Total number of records in data files in the snapshot before applying deletes | Review Comment: its my thought but wdyt: Total number of records in live data files in the snapshot (does not account for position/equality deletes or deletion vectors) more consistent with earlier. Also applying deletes is ambiguous as it may also mean a deleted file, ie 'deleted-records'. We actually do apply those.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
