CTTY commented on code in PR #2871: URL: https://github.com/apache/iceberg-rust/pull/2871#discussion_r3694547144
########## crates/iceberg/src/spec/table_properties.rs: ########## Review Comment: I just realized that rust `parse::<bool>` will only accept lower case "true" or "false", this will cause valid configuration on the java side like `write.object-storage.partitioned-paths=False` auto fall back to default(`true`) on the rust side. We should fix this by adding a new `parse_property_ignore_case` and add necessary comments, also need to migrate the existing `parse::<bool>` to use the new function. we can do it in a follow up PR tho -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
