fallintoplace opened a new pull request, #1627: URL: https://github.com/apache/iceberg-go/pull/1627
V3 manifest writers advance the row ID cursor using manifest row counts. Near `math.MaxInt64`, that addition could wrap and produce negative row IDs. Negative initial IDs and negative manifest counts were accepted as well. Validate the starting ID and row counts, use checked arithmetic before assigning ranges, and leave the cursor unchanged when validation fails. Tests cover negative starts, negative counts, overflow in manifest lists, and overflow in `WriteManifestV3`. Tested with: `go test .` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
