uros-b commented on code in PR #17468:
URL: https://github.com/apache/iceberg/pull/17468#discussion_r3699775193
##########
gcp/src/main/java/org/apache/iceberg/gcp/gcs/PrefixedStorage.java:
##########
@@ -158,6 +158,10 @@ private Credentials credentials(GCPProperties properties) {
return NoCredentials.getInstance();
} else if (properties.impersonateServiceAccount().isPresent()) {
return buildImpersonatedCredentials(properties);
+ } else if (properties.tokenCredentialProvider().isPresent()) {
Review Comment:
Also, missing PrefixedStorage wiring test: TestGcsTokenCredentialProviders
tests the factory in isolation and TestGCPProperties tests property parsing,
but no test constructs a PrefixedStorage with gcs.token-credential-provider set
and verifies the resulting Storage client receives the provider's
GoogleCredentials. TestPrefixedStorage.validParameters already demonstrates the
pattern with gcs.oauth2.token (mock credential -> assert setCredentials
called). Also missing: a test for the impersonation + provider coexistence
behavior (whichever resolution is chosen above). A wiring test is needed to
gate confidence in the new branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
