uros-b commented on code in PR #17461:
URL: https://github.com/apache/iceberg/pull/17461#discussion_r3700435479
##########
parquet/src/test/java/org/apache/iceberg/parquet/TestParquet.java:
##########
@@ -288,6 +288,55 @@ public void testColumnStatisticsEnabled() throws Exception
{
}
}
+ @Test
+ public void testMultipleColumnStatisticsDisabled() throws Exception {
+ Schema schema =
+ new Schema(
+ optional(1, "int_field", IntegerType.get()),
+ optional(2, "string_field", Types.StringType.get()),
+ optional(3, "long_field", Types.LongType.get()));
+
+ File file = createTempFile(temp);
+
+ List<GenericData.Record> records = Lists.newArrayListWithCapacity(5);
+ org.apache.avro.Schema avroSchema =
AvroSchemaUtil.convert(schema.asStruct());
+ for (int i = 1; i <= 5; i++) {
+ GenericData.Record record = new GenericData.Record(avroSchema);
+ record.put("int_field", i);
+ record.put("string_field", "test");
+ record.put("long_field", (long) i);
+ records.add(record);
+ }
+
+ write(
+ file,
+ schema,
+ ImmutableMap.<String, String>builder()
+ .put(PARQUET_COLUMN_STATS_ENABLED_PREFIX + "int_field", "false")
+ .put(PARQUET_COLUMN_STATS_ENABLED_PREFIX + "string_field", "false")
+ .put(PARQUET_COLUMN_STATS_ENABLED_PREFIX + "long_field", "true")
+ .buildOrThrow(),
+ ParquetAvroWriter::buildWriter,
+ records.toArray(new GenericData.Record[] {}));
+
+ InputFile inputFile = Files.localInput(file);
+
+ try (ParquetFileReader reader =
ParquetFileReader.open(ParquetIO.file(inputFile))) {
+ for (BlockMetaData block : reader.getFooter().getBlocks()) {
+ for (ColumnChunkMetaData column : block.getColumns()) {
+ boolean emptyStats = column.getStatistics().isEmpty();
+ if (column.getPath().toDotString().equals("int_field")) {
+ assertThat(emptyStats).as("int_field has statistics
disabled").isEqualTo(true);
+ } else if (column.getPath().toDotString().equals("string_field")) {
+ assertThat(emptyStats).as("string_field has statistics
disabled").isEqualTo(true);
+ } else if (column.getPath().toDotString().equals("long_field")) {
+ assertThat(emptyStats).as("long_field has statistics
enabled").isEqualTo(false);
+ }
+ }
+ }
+ }
+ }
+
Review Comment:
No production fix is needed: the multi-column statistics disable path
already works on current main. PR #17365 (open, approved) adds equivalent test
coverage without any production change and CI is green, confirming the
multi-column path is not broken. This PR's test
testMultipleColumnStatisticsDisabled does not guard a real regression; it
passes with or without the conf.set because the actual enforcement runs through
ParquetProperties.Builder, not conf.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
