xanderbailey commented on code in PR #2965: URL: https://github.com/apache/iceberg-rust/pull/2965#discussion_r3722322952
########## crates/iceberg/src/io/storage/config/gcs.rs: ########## @@ -30,6 +30,16 @@ use crate::io::is_truthy; /// Google Cloud Project ID. pub const GCS_PROJECT_ID: &str = "gcs.project-id"; /// Google Cloud Storage endpoint. +/// +pub const GCS_SERVICE_HOST: &str = "gcs.service.host"; +/// Google Cloud Storage endpoint. +/// +/// Deprecated: use [`GCS_SERVICE_HOST`] instead. This key never existed in the +/// Iceberg Java or PyIceberg implementations (both use `gcs.service.host`), so +/// endpoints vended by a REST catalog or copied from another engine were +/// silently ignored. It is still read as a fallback for backwards +/// compatibility. +#[deprecated(since = "0.10.1", note = "use GCS_SERVICE_HOST instead")] pub const GCS_SERVICE_PATH: &str = "gcs.service.path"; Review Comment: If we prefer to hard break here and include this in the release docs for the next release, I'm also happy to do that. Wasn't sure what the right thing to do here was. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
