alexandre-normand commented on PR #1654:
URL: https://github.com/apache/iceberg-go/pull/1654#issuecomment-5195381900
I think I prematurely celebrated. It seems like goccy/go-json is triggering
a panic in the `TestV3PartitionStatisticsRoundTrip` test.
```
--- FAIL: TestV3PartitionStatisticsRoundTrip (0.00s)
panic: runtime error: invalid memory address or nil pointer dereference
[recovered, repanicked]
[signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x1027fddd4]
goroutine 49 [running]:
testing.tRunner.func1.2({0x10555a580, 0x105a88ef0})
/opt/homebrew/opt/go/libexec/src/testing/testing.go:1974 +0x1a0
testing.tRunner.func1()
/opt/homebrew/opt/go/libexec/src/testing/testing.go:1977 +0x318
panic({0x10555a580?, 0x105a88ef0?})
/opt/homebrew/opt/go/libexec/src/runtime/panic.go:860 +0x12c
encoding/json.(*encodeState).marshal.func1()
/opt/homebrew/opt/go/libexec/src/encoding/json/encode.go:339 +0x70
panic({0x10555a580?, 0x105a88ef0?})
/opt/homebrew/opt/go/libexec/src/runtime/panic.go:860 +0x12c
github.com/goccy/go-json/internal/encoder/vm.Run(0x732f6abe4ea0,
{0x732f6a9f2400?, 0x0?, 0x400?}, 0x732f6a6e44d0?)
/Users/alex.normand/go/pkg/mod/github.com/goccy/[email protected]/internal/encoder/vm/vm.go:26
+0x64
github.com/goccy/go-json.encodeRunCode(0x732f6abe4ea0?, {0x732f6a9f2400?,
0x105b246d0?, 0x732f6a143a50?}, 0x732f6abe4ea0?)
/Users/alex.normand/go/pkg/mod/github.com/goccy/[email protected]/encode.go:310
+0x64
github.com/goccy/go-json.encode(0x732f6abe4ea0, {0x105822c80,
0x732f6ad88ad0})
/Users/alex.normand/go/pkg/mod/github.com/goccy/[email protected]/encode.go:235
+0x1e0
github.com/goccy/go-json.marshal({0x105822c80, 0x732f6ad88ad0}, {0x0, 0x0,
0x105832a01?})
/Users/alex.normand/go/pkg/mod/github.com/goccy/[email protected]/encode.go:150
+0xb0
github.com/goccy/go-json.MarshalWithOption(...)
/Users/alex.normand/go/pkg/mod/github.com/goccy/[email protected]/json.go:185
github.com/goccy/go-json.Marshal({0x105822c80?, 0x732f6ad88ad0?})
/Users/alex.normand/go/pkg/mod/github.com/goccy/[email protected]/json.go:170
+0x30
github.com/apache/iceberg-go/table.(*metadataV3).MarshalJSON(0x732f6a762900)
/Users/alex.normand/projects/iceberg-go/table/metadata.go:2665 +0x108
encoding/json.marshalerEncoder(0x732f6ab84600, {0x105832ae0?,
0x732f6a762900?, 0x0?}, {0x0?, 0x0?})
/opt/homebrew/opt/go/libexec/src/encoding/json/encode.go:483 +0x9c
encoding/json.(*encodeState).reflectValue(0x732f6ab84600, {0x105832ae0?,
0x732f6a762900?, 0x0?}, {0x0?, 0x0?})
/opt/homebrew/opt/go/libexec/src/encoding/json/encode.go:367 +0x70
encoding/json.(*encodeState).marshal(0x105480480?, {0x105832ae0?,
0x732f6a762900?}, {0xb0?, 0x65?})
/opt/homebrew/opt/go/libexec/src/encoding/json/encode.go:343 +0xac
encoding/json.Marshal({0x105832ae0, 0x732f6a762900})
/opt/homebrew/opt/go/libexec/src/encoding/json/encode.go:209 +0x8c
github.com/apache/iceberg-go/table.TestV3PartitionStatisticsRoundTrip(0x732f6b005b08)
/Users/alex.normand/projects/iceberg-go/table/metadata_internal_test.go:2089
+0x3c0
testing.tRunner(0x732f6b005b08, 0x105874818)
/opt/homebrew/opt/go/libexec/src/testing/testing.go:2036 +0xc4
created by testing.(*T).Run in goroutine 1
/opt/homebrew/opt/go/libexec/src/testing/testing.go:2101 +0x3a8
```
I tried figuring out why and finding a fix for that but no luck so far and I
have to switch to some other higher priority work. I'll come back to it at some
point but I'll mark this as draft in the meantime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
