u70b3 commented on PR #2752: URL: https://github.com/apache/iceberg-rust/pull/2752#issuecomment-5208073698
Hi @CTTY @blackmwk, could you help review this core COW rewrite primitive when you have time? It's been waiting on review for a bit, so I'd like to widen the reviewer pool — any feedback is welcome. Quick context to make the review easier: - **Scope**: this is the core primitive of the COW series (#2269) only. It plans candidate files, rewrites them, and returns removed/added/unchanged `DataFile` sets plus stats. It intentionally does not commit table metadata — the commit adapters are left to follow-ups (#2185 OverwriteAction, #2203/#2678 RowDelta). - **Read-path reuse**: candidate planning goes through the existing scan path (manifest pruning + delete-file application, consistent with #2367), then clears only the row predicate so each chosen file is rewritten in full. - **Structure**: the diff splits cleanly into candidate planning / batch rewriter trait / replacement writer / orchestration builder, so it can be reviewed piece by piece. Tests cover DELETE-style, UPDATE-style, no-op, full-file delete, and writer edge cases. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
