danielcweeks commented on code in PR #17337:
URL: https://github.com/apache/iceberg/pull/17337#discussion_r3739065898
##########
core/src/main/java/org/apache/iceberg/rest/responses/LoadTableResponse.java:
##########
@@ -87,12 +91,18 @@ public List<Credential> credentials() {
return credentials != null ? credentials : ImmutableList.of();
}
+ /** Catalog-provided labels, or an empty instance when the response carries
no labels. */
Review Comment:
This is over-commenting. We don't need it (just duplicates the codde)
##########
core/src/main/java/org/apache/iceberg/rest/responses/LoadViewResponse.java:
##########
@@ -31,6 +32,12 @@ public interface LoadViewResponse extends RESTResponse {
Map<String, String> config();
+ /** Catalog-provided labels, or an empty instance when the response carries
no labels. */
Review Comment:
This is over-commenting. We don't need it (just duplicates the codde)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
