mattfaltyn commented on PR #1558: URL: https://github.com/apache/iceberg-go/pull/1558#issuecomment-5225303731
Ready for re-review @zeroshade @laskoviymishka. I merged current main without rewriting reviewed history and preserved the newer BBox handling. The remaining review items are addressed in 97a0c39: - top-level geo defaults fail open during missing-column translation instead of aborting the scan - binary/fixed defaults use one hex-first codec across filtering and Arrow projection, with legacy iceberg-go v0.6.0 base64 compatibility - new metadata writes serialize binary/fixed defaults as spec-compliant lowercase hex - filter/projection consistency, timestamp, boolean, geo, legacy base64, and empty/fixed-width cases are covered - nested required-parent folding remains intentionally out of scope Local validation passed: go test ./..., go test -race ./codec/... ./table/..., golangci-lint v2.8.0, Linux/s390x cross-build, focused regressions, and git diff --check. All GitHub checks, including Spark 3.5 and 4.0 integrations, are green. I replied to each open inline thread and left reviewer-owned threads unresolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
