1991santhu opened a new issue, #1716: URL: https://github.com/apache/iceberg-go/issues/1716
Raised by @laskoviymishka during review of #1640 and deferred as out of scope there. `catalog/hive/options.go` defines the lock-check tuning as: | Key | Default | |---|---| | `lock-check-min-wait-time` | 100ms | | `lock-check-max-wait-time` | 1 minute | | `lock-check-retries` | 4 | These do not line up with the Java implementation's property names or its default values, so the same table property set cannot be carried across the two clients, and an operator tuning one has to re-derive the settings for the other. Two separate questions here, worth deciding together: 1. **Names** — should the Go client accept Java's property keys, either as the primary names or as aliases? 2. **Defaults** — should the values match Java's, or is divergence acceptable as long as it is documented? Both are user-visible changes for anyone already setting these, which is why this is a tracking issue rather than a patch. One adjacent robustness note from the same review: `options.go` parses these with `time.ParseDuration`, which accepts negative durations, and nothing rejects `min-wait-time >= max-wait-time`. Neither is currently dangerous — `applyJitter` guards both — but validating at parse time would make the contract clearer than relying on downstream defensiveness. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
