stevenzwu commented on code in PR #16285:
URL: https://github.com/apache/iceberg/pull/16285#discussion_r3741929968
##########
core/src/test/java/org/apache/iceberg/TestTrackingBuilder.java:
##########
@@ -272,15 +287,69 @@ void manifestDVPositionsProduceModified() {
assertThat(modified.deletedPositions()).isEqualTo(deletedBytes);
}
+ @Test
+ void manifestPositionsWithColumnFilesUpdated() {
+ ByteBuffer deletedBytes = ByteBuffer.wrap(new byte[] {1});
+ Tracking withDeletedPositions =
+ TrackingBuilder.from(manifestSourceTracking(), 999L)
+ .columnFilesUpdated()
+ .deletedPositions(deletedBytes)
Review Comment:
> I don't think we plan to add column files for leaf manifest at this point
We will use column files for leaf manifests in v4. we should keep this test.
I was mainly alluding to if we should cover the column update for data file
cases, where deletedPositions is not applicable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
