nastra commented on code in PR #17513:
URL: https://github.com/apache/iceberg/pull/17513#discussion_r3747466752
##########
api/src/main/java/org/apache/iceberg/Schema.java:
##########
@@ -233,6 +234,13 @@ private Map<Integer, String> lazyIdToName() {
return idToName;
}
+ private Map<Integer, Integer> lazyIdToParent() {
+ if (idToParent == null) {
+ this.idToParent = TypeUtil.indexParents(struct);
+ }
+ return idToParent;
Review Comment:
I was mainly keeping it in-sync with all the other methods. I think it we
want to synchronize, then we should probably do this across the board?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
