mxm commented on code in PR #17152:
URL: https://github.com/apache/iceberg/pull/17152#discussion_r3748912340
##########
kafka-connect/kafka-connect/src/test/java/org/apache/iceberg/connect/data/TestRecordUtils.java:
##########
@@ -90,4 +95,23 @@ public void testExtractFromRecordValueMapNull() {
result = RecordUtils.extractFromRecordValue(val, "xkey");
assertThat(result).isNull();
}
+
+ @Test
+ public void createTableWriterReadsIdColumnsForNamespacedTable() {
Review Comment:
Should we reflect in the name this is a negative test?
```suggestion
public void createTableWriterWithNonMatchingNamespace() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
