alessandro-nori commented on code in PR #1749:
URL: https://github.com/apache/iceberg-go/pull/1749#discussion_r3749809469
##########
catalog/rest/rest.go:
##########
@@ -1607,7 +1632,17 @@ func (r *Catalog) RegisterTable(ctx context.Context,
identifier table.Identifier
return r.tableFromResponse(ctx, identifier, ret.Metadata,
ret.MetadataLoc, config, credsVended)
}
+// Loads a table from the catalog. It implements [catalog.Catalog].
func (r *Catalog) LoadTable(ctx context.Context, identifier table.Identifier)
(*table.Table, error) {
+ return r.loadTableWithMode(ctx, identifier, "")
Review Comment:
in the [Java
implementation](https://github.com/apache/iceberg/blob/d7d3bd5c3788b882f52fa79c44cf09a11459deab/core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java#L266)
`snapshotMode` is configured once at catalog initialization and not per
request.
I wonder if we should follow the same approach and, like we did for
`pageSize`, extract `snapshotMode` from the context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
