bryanck commented on code in PR #17499: URL: https://github.com/apache/iceberg/pull/17499#discussion_r3754520658
########## spark/v4.1/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ########## @@ -45,6 +47,12 @@ case class ResolveViews(spark: SparkSession) extends Rule[LogicalPlan] with Look protected lazy val catalogManager: CatalogManager = spark.sessionState.catalogManager + // Spark's own view schema binding confs, SQLConf.VIEW_SCHEMA_BINDING_ENABLED and + // VIEW_SCHEMA_COMPENSATION. Referenced by name because they were added in Spark 4.0 and this + // rule is also compiled against Spark 3.5. Both default to true. + private val sparkViewSchemaBindingMode = "spark.sql.legacy.viewSchemaBindingMode" + private val sparkViewSchemaCompensation = "spark.sql.legacy.viewSchemaCompensation" Review Comment: These are available in Spark 4.0 and 4.1, can we remove them here and only add them for 3.5? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
