badalprasadsingh commented on PR #1637:
URL: https://github.com/apache/iceberg-go/pull/1637#issuecomment-5251547825

   >Branch write planning still reads main
   >
   >The blocking issue outside the changed lines is that snapshot production 
now parents on the target branch, while high->level destructive-write planning 
and validation still inspect meta.currentSnapshot() (main). The resulting 
snapshot can >therefore be parented on the branch while its 
deletion/replacement plan describes main. A full branch overwrite can >retain 
branch-only files, and replace operations can reject or target the wrong files.
   
   I have fixed **`RewriteManifests`**
   
   But for the others, intentionally out of scope for this PR, tracked by 
#1638. Will raise a PR for it soon! 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to