ryanworl commented on issue #1760: URL: https://github.com/apache/iceberg-go/issues/1760#issuecomment-5256202279
Went back and double-checked the spec on this, and it's pretty clear-cut — figured I'd add the references here to save anyone the digging. The [Manifests section](https://iceberg.apache.org/spec/#manifests) actually treats the file-level key as the source of truth for what kind of manifest it is: > Whether a manifest is a data manifest or a delete manifest is stored in manifest metadata. And the metadata table right below that lists `content` as required for v2/v3, with the value being "data" or "deletes". Appendix E says the same thing in the v2 format changes. Since DVs are tracked in delete manifests, this one should say `deletes`. A reader relying only on the file metadata (which the spec seems to encourage!) would misclassify these manifests even without cross-checking the list entry — so this isn't just about iceberg-go being strict. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
