dgvj-work opened a new pull request, #1763: URL: https://github.com/apache/iceberg-go/pull/1763
## Summary - Accept Java's `iceberg.hive.lock-check-min-wait-ms` / `iceberg.hive.lock-check-max-wait-ms` as the primary Hive lock-check property keys (integer milliseconds). - Keep the existing Go duration-string keys as aliases; Java keys win when both are set. - Match Java defaults (`50ms` / `5s`) and ignore invalid values (non-positive waits/retries, or min ≥ max) at parse time. - Document the remaining Go-specific `lock-check-retries` vs Java `iceberg.hive.lock-timeout-ms` gap as follow-up. Fixes #1716 ## Test plan - [x] `go test ./catalog/hive/ -count=1` - [x] Cover Java keys, legacy aliases, precedence, defaults, and invalid-value handling - [ ] CI green Made with [Cursor](https://cursor.com) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
