dgvj-work commented on PR #1707: URL: https://github.com/apache/iceberg-go/pull/1707#issuecomment-5255926013
Thanks for the review — addressed in bf931dd: - Docs/help now state that the default CLI binary only ships `sqliteshim` / `sqlite`; other dialects need a custom build. - Kept `mergeConf` populating `uri` / `warehouse` / `credential` from the config file, expanded tests for that, and always pass `credential` into the SQL props so EnvConfig can't bleed through. - DynamoDB now fails via `output.Error` before `initCatalog`. - Added the `--catalog sql` without `--sql-driver` negative test asserting `must provide driver`. Ready for another pass when you have a moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
