rdblue commented on code in PR #17413:
URL: https://github.com/apache/iceberg/pull/17413#discussion_r3762261593
##########
api/src/main/java/org/apache/iceberg/expressions/UnboundPredicate.java:
##########
@@ -127,15 +127,15 @@ private Expression bindUnaryOperation(StructType struct,
BoundTerm<T> boundTerm)
switch (op()) {
case IS_NULL:
if (!boundTerm.producesNull()
- && allAncestorFieldsAreRequired(struct,
boundTerm.ref().fieldId())) {
+ && !TypeUtil.isNullable(struct.asSchema(),
boundTerm.ref().fieldId())) {
Review Comment:
Don't create a schema from a struct. Instead, add a method that accepts a
struct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
