blackmwk commented on code in PR #2987:
URL: https://github.com/apache/iceberg-rust/pull/2987#discussion_r3763405772
##########
crates/property-macro/README.md:
##########
@@ -141,14 +145,13 @@ struct TableLikeProperties {
#[property(prefix = COLUMN_FPP_PREFIX, getter)]
column_fpp: HashMap<String, f64>,
- /// A single-key parser can validate and normalize a property value.
+ /// A single-key parser can validate and normalize an explicitly
configured path.
#[property(
key = LOCATION,
- default = "warehouse",
- parse_with = parse_location,
- getter
+ default = None,
+ parse_with = parse_location
)]
- location: String,
+ location: Option<String>,
Review Comment:
Oh, I'm wrong, we should still keep the getter. The logic in method is
infeasible since there is no property about table location.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
