mengna-lin commented on PR #16094: URL: https://github.com/apache/iceberg/pull/16094#issuecomment-5262302072
> > > I don’t think we should use column name in table property. Column name is not unique. > > > > > > I follow the pattern of current table property. https://github.com/Gerrrr/iceberg/blob/main/docs/docs/configuration.md. For example, bloom filter config is also based on column name. > > I don't know about the history of bloom filter column. But this doesn't look like the right thing to do. We shouldn't take this approach just because there's precedence. Could you explain more on what do you mean by column name is not unique? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
