manuzhang opened a new pull request, #884: URL: https://github.com/apache/iceberg-cpp/pull/884
## What changed - remove the stale `MergingSnapshotUpdate` event-reporting TODO - add focused coverage proving a merge-based snapshot update emits one `CommitReport` - verify the report carries the table name, operation, created snapshot ID, sequence number, and summary-derived file and record counts ## Why The TODO predates commit metrics integration and still says C++ has no equivalent reporting mechanism. Snapshot updates now report successful commits through `MetricsReporter`, but `MergingSnapshotUpdate` did not have direct regression coverage for that behavior. This keeps reporting centralized in `SnapshotUpdate` while testing the contract for merge-based updates. ## Validation - `cmake --build build --target table_update_test -j2` - `build/src/iceberg/test/table_update_test --gtest_filter='MergingSnapshotUpdateTest.*'` (79 tests passed) - `clang-format --dry-run --Werror src/iceberg/test/merging_snapshot_update_test.cc src/iceberg/update/merging_snapshot_update.h` - `git diff --check` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
