bobmerevel commented on code in PR #16846:
URL: https://github.com/apache/iceberg/pull/16846#discussion_r3765379218


##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/actions/BaseSparkAction.java:
##########
@@ -135,6 +136,9 @@ protected JobGroupInfo newJobGroupInfo(String groupId, 
String desc) {
   }
 
   protected Table newStaticTable(TableMetadata metadata, FileIO io) {
+    Preconditions.checkNotNull(

Review Comment:
   This issue was caused by a bug in the external catalog implementation, not 
by Iceberg itself. After fixing the catalog implementation, the issue was 
resolved even with older Iceberg versions. Therefore, I didn't backport this 
change to older versions. It is only intended as a safeguard for newer 
versions, as @ebyhr said. The current and older versions work correctly without 
it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to