fallintoplace opened a new pull request, #1781: URL: https://github.com/apache/iceberg-go/pull/1781
## Summary - load one `FileIO` for each local planning operation - reuse it for the manifest list and concurrent manifest entry reads - keep empty-table planning lazy so it still skips FileIO construction - leave remote planning and its plan-scoped IO lifecycle unchanged ## Benchmark `BenchmarkPlanFilesFileIOReuse` plans real Avro manifests from an in-memory filesystem and reports factory loads directly. | Manifests | Before | After | | ---: | ---: | ---: | | 1 | 2 loads/op | 1 load/op | | 10 | 11 loads/op | 1 load/op | | 100 | 101 loads/op | 1 load/op | The in-memory wall time stays close to noise. The useful part here is removing repeated backend setup from cloud FileIO factories. ## Tests - `go test ./table -count=1` - repository packages excluding the unchanged `io/gocloud` package - `go test -race ./table -run ^TestPlanFilesReusesFileIO$ -count=1` - `go vet ./table/...` - `golangci-lint run --timeout=10m ./table/...` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
