xanderbailey commented on code in PR #2884:
URL: https://github.com/apache/iceberg-rust/pull/2884#discussion_r3766990083
##########
crates/iceberg/src/io/object_cache.rs:
##########
@@ -103,8 +103,8 @@ impl ObjectCache {
/// or retrieves one from FileIO and parses it if not present
pub(crate) async fn get_manifest(&self, manifest_file: &ManifestFile) ->
Result<Arc<Manifest>> {
if self.cache_disabled {
- return manifest_file
- .load_manifest(&self.file_io)
+ return ManifestReader::new(self.file_io.clone())
+ .read(manifest_file)
Review Comment:
object cache sits below table so we must construct this manually. We do the
same for `ManifestListReader`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
