anoopj commented on code in PR #17608:
URL: https://github.com/apache/iceberg/pull/17608#discussion_r3769097244
##########
api/src/main/java/org/apache/iceberg/Metrics.java:
##########
@@ -75,6 +75,19 @@ public Metrics(
null);
}
+ /**
+ * Creates a new metrics instance.
+ *
+ * @param rowCount the number of rows (records) in the file, or null if
unknown
+ * @param columnSizes a map of field id to the size in bytes of the column,
or null if unknown
+ * @param valueCounts a map of field id to the number of all values
(including nulls, NaN, and
+ * repeated), or null if unknown
+ * @param nullValueCounts a map of field id to the number of null values, or
null if unknown
+ * @param nanValueCounts a map of field id to the number of NaN values, or
null if unknown
+ * @param lowerBounds a map of field id to the lower bound of the column, or
null if unknown
+ * @param upperBounds a map of field id to the upper bound of the column, or
null if unknown
+ * @param originalTypes a map of field id to the original type of the
column, or null if unknown
Review Comment:
```suggestion
* @param originalTypes a map of field id to the original type of the
lower/upper bound, or null
* if unknown
```
##########
api/src/main/java/org/apache/iceberg/Metrics.java:
##########
@@ -75,6 +75,19 @@ public Metrics(
null);
}
+ /**
+ * Creates a new metrics instance.
+ *
+ * @param rowCount the number of rows (records) in the file, or null if
unknown
+ * @param columnSizes a map of field id to the size in bytes of the column,
or null if unknown
+ * @param valueCounts a map of field id to the number of all values
(including nulls, NaN, and
+ * repeated), or null if unknown
+ * @param nullValueCounts a map of field id to the number of null values, or
null if unknown
+ * @param nanValueCounts a map of field id to the number of NaN values, or
null if unknown
+ * @param lowerBounds a map of field id to the lower bound of the column, or
null if unknown
+ * @param upperBounds a map of field id to the upper bound of the column, or
null if unknown
+ * @param originalTypes a map of field id to the original type of the
column, or null if unknown
Review Comment:
This is to match the getter of `originalTypes`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
