anoopj commented on code in PR #17617:
URL: https://github.com/apache/iceberg/pull/17617#discussion_r3769261166
##########
spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/data/InternalRowConverter.java:
##########
@@ -117,4 +121,16 @@ private static byte[] toByteArray(Object value) {
throw new UnsupportedOperationException(
"Unsupported binary value class: " + value.getClass().getName());
}
+
+ private static VariantVal toVariantVal(Variant variant) {
Review Comment:
optional: looks like this code is duplicate? Not a big deal since it's test
code, optionally extract it to a shared helper?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
