rambleraptor commented on code in PR #3645:
URL: https://github.com/apache/iceberg-python/pull/3645#discussion_r3769714834
##########
pyiceberg/table/sorting.py:
##########
@@ -101,7 +101,9 @@ def set_null_order(cls, values: dict[str, Any]) ->
dict[str, Any]:
@classmethod
def map_source_ids_onto_source_id(cls, data: Any) -> Any:
if isinstance(data, dict):
- if "source-id" not in data and "source-ids" in data:
+ if "source-ids" in data:
Review Comment:
```suggestion
if "source-ids" in data and "source-id" in data:
raise ValueError("source-id and source-ids are mutually
exclusive")
elif "source-ids" in data:
```
style nit. Nested if statements can confusing to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
