uros-b commented on code in PR #17627:
URL: https://github.com/apache/iceberg/pull/17627#discussion_r3773321848
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -232,36 +205,13 @@ private boolean credentialProvided() {
@Value.Check
protected void check() {
Preconditions.checkArgument(
- properties().containsKey(S3_SIGNER_URI)
- || properties().containsKey(RESTCatalogProperties.SIGNER_URI)
+ properties().containsKey(RESTCatalogProperties.SIGNER_URI)
|| properties().containsKey(CatalogProperties.URI),
"S3 signer service URI is required");
-
- if (properties().containsKey(S3_SIGNER_URI)
- && !properties().containsKey(RESTCatalogProperties.SIGNER_URI)) {
- LOG.warn(
- "S3 signer URI is configured via deprecated property {}, this won't
be supported in future releases. "
- + "Please use {} instead.",
- S3_SIGNER_URI,
- RESTCatalogProperties.SIGNER_URI);
- }
-
- if (properties().containsKey(S3_SIGNER_ENDPOINT)
- && !properties().containsKey(RESTCatalogProperties.SIGNER_ENDPOINT)) {
- LOG.warn(
- "Signer endpoint is configured via deprecated property {}, this
won't be supported in future releases. "
- + "Please use {} instead.",
- S3_SIGNER_ENDPOINT,
- RESTCatalogProperties.SIGNER_ENDPOINT);
- }
-
- // TODO change to required in 1.12.0
- if (!properties().containsKey(S3_SIGNER_ENDPOINT)
- && !properties().containsKey(RESTCatalogProperties.SIGNER_ENDPOINT)) {
- LOG.warn(
- "Signer endpoint is not set, this won't be supported in future
releases. Using deprecated default: {}",
- S3_SIGNER_DEFAULT_ENDPOINT);
- }
+ Preconditions.checkArgument(
+ properties().containsKey(RESTCatalogProperties.SIGNER_ENDPOINT),
+ "S3 signer endpoint (%s) is required",
+ RESTCatalogProperties.SIGNER_ENDPOINT);
}
Review Comment:
The change in this file is stricter than a pure deprecation-alias removal.
Beyond stripping the s3.signer.uri/s3.signer.endpoint aliases, it also removes
the working "v1/aws/s3/sign" implicit default (S3_SIGNER_DEFAULT_ENDPOINT),
meaning users who set s3.remote-signing-enabled=true without ever configuring
an explicit endpoint now fail at construction with IllegalArgumentException.
The 1.11.0 LOG.warn, the @deprecated "no replacement, remove in 1.12.0" on
S3_SIGNER_DEFAULT_ENDPOINT, and the updated SIGNER_ENDPOINT Javadoc ("If remote
signing has been requested, this must be set") all point toward requiring the
endpoint in 1.12.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
