Revanth14 commented on code in PR #1505:
URL: https://github.com/apache/iceberg-go/pull/1505#discussion_r3781108363


##########
internal/recipe/docker-compose.yml:
##########
@@ -46,7 +46,11 @@ services:
       retries: 12
       start_period: 30s
   rest:
-    image: apache/iceberg-rest-fixture:1.10.1
+    # 1.10.1 predates the fixture's scan-planning implementation. Pin the
+    # multi-platform image built from apache/iceberg@b0df3ca so the Java wire
+    # compatibility tests are reproducible even though the released tag is not
+    # available yet.
+    image: 
apache/iceberg-rest-fixture:latest@sha256:db8de90b5b7693d4ac334c336f91d9bbe320d7b19f4f514d26de84cdfbcbfe8d

Review Comment:
   Agreed. I split the fixtures into two services:
   
   - `rest` remains pinned to the released `1.10.1` image on port `8181`.
   - `rest-scan-planning` uses the digest-pinned scan-planning image on port 
`8182`.
   
   The regular REST integration tests therefore stay on the stable released 
fixture, while only the dedicated scan-planning tests depend on the pre-release 
image.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to