ebyhr commented on code in PR #17646:
URL: https://github.com/apache/iceberg/pull/17646#discussion_r3783139968
##########
core/src/test/java/org/apache/iceberg/rest/TestHTTPClient.java:
##########
@@ -134,6 +140,81 @@ public void testPostSuccess() throws Exception {
testHttpMethodOnSuccess(HttpMethod.POST);
}
+ @Test
+ public void testPostUnicodeBody() throws Exception {
Review Comment:
These tests aren't valid regression tests because they pass even if we
revert HTTPClient.java.
What if we use JUnit Pioneer's `@DefaultLocale` annotation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
