rdblue commented on code in PR #17413: URL: https://github.com/apache/iceberg/pull/17413#discussion_r3786012975
########## core/src/main/java/org/apache/iceberg/expressions/InclusiveStatsEvaluator.java: ########## @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.expressions; Review Comment: I dug into the issue and had Claude code diagnose the problem. It looks like this is expected behavior because the new method check triggers when the new method is publicly visible, without checking that the old version was publicly visible. That's in contrast with other checks, which validate whether both old and new are visible (this is why the return type change for `fieldStats` is not flagged). Claude did a thorough job, even decompiling the revapi Jar to find out exactly what the checks are doing. I think it's reasonable to move forward by suppressing these as false positives. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
