szehon-ho commented on code in PR #17581:
URL: https://github.com/apache/iceberg/pull/17581#discussion_r3788177470
##########
core/src/main/java/org/apache/iceberg/ManifestsTable.java:
##########
@@ -120,7 +120,7 @@ static List<StaticDataTask.Row> partitionSummariesToRows(
return null;
}
- List<StaticDataTask.Row> rows = Lists.newArrayList();
+ List<StaticDataTask.Row> rows =
Lists.newArrayListWithCapacity(summaries.size());
Review Comment:
This one is correct but hard to motivate: `summaries` has one entry per
partition field, so it is almost always well under `ArrayList`'s default
capacity of 10 and no growth happens. Could you say what prompted the change (a
profile, a benchmark, a static-analysis rule)? If there's no measurement behind
it, I'd lean toward leaving this site alone and keeping the PR to the
`ManifestFiles` cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
