wombatu-kun commented on code in PR #16910:
URL: https://github.com/apache/iceberg/pull/16910#discussion_r3791838652
##########
core/src/main/java/org/apache/iceberg/RewriteTablePathUtil.java:
##########
@@ -340,6 +418,8 @@ private static List<ManifestFile>
manifestFilesInSnapshot(FileIO io, Snapshot sn
* @param sourcePrefix source prefix that will be replaced
* @param targetPrefix target prefix that will replace it
* @return a copy plan of content files in the manifest that was rewritten
+ * @see #rewriteDataManifestAndMeasureLength which also returns the
rewritten manifest length, for
+ * callers that need to record manifest_length in the manifest list
*/
public static RewriteResult<DataFile> rewriteDataManifest(
Review Comment:
Same answer as the rewriteManifestList thread: @Deprecated commits core to a
removal release, which is a committer's call rather than part of a bug fix. The
javadoc already points at the overload that returns the length.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
