daviddallakyan2005 commented on PR #3285: URL: https://github.com/apache/iceberg-python/pull/3285#issuecomment-5307669147
Checked this out locally. `make test PYTEST_ARGS="-v -k equality"` gave 157 passed. @arjun-panchmatia-mechademy the CDC failure is still present on this branch, which is expected. `plan_files` still raises before the new index is used: ``` ValueError: PyIceberg does not yet support equality deletes: https://github.com/apache/iceberg/issues/6568 ``` REST planning raises `NotImplementedError` the same way. I am taking the PyArrow reads geruh outlined on #3270. One gap in the index itself: `_eq_applies_to_data_file` looks up equality field types on the current schema. int to long is fine after #3293, but the case Java actually fixed in apache/iceberg#15268 (equality deletes on a column later dropped) still crashes: ``` ValueError: Could not find field with id: 1 ``` GitHub currently marks this PR CONFLICTING (146 commits behind main). I am rebasing the index onto main and adding apply on read plus that dropped field test. I will credit @rambleraptor for the index work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
