moomindani commented on PR #3804: URL: https://github.com/apache/iceberg-python/pull/3804#issuecomment-5310405685
Thanks for catching and fixing this, @daviddallakyan2005, and sorry for the noise — the broken call came in with #3476. For the record on the root cause: #3476's last commit was 2026-06-18, and #3491 deprecated `PuffinFile.to_vector()` on 2026-06-25. The test was green when it last ran and only went stale while the PR waited for a merge, which landed on 08-15 without a rebase — so CI never ran it against the current `main`. The fix looks right to me. `DeletionVector.to_vector()` isn't deprecated, and the assertions are equivalent since the old loop never used the data file path key. I also checked that `test_deletes.py:1084` was the only remaining call site of the deprecated method on `main`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
