zhjwpku commented on code in PR #889:
URL: https://github.com/apache/iceberg-cpp/pull/889#discussion_r3794145120
##########
src/iceberg/util/location_util.cc:
##########
@@ -17,20 +17,16 @@
* under the License.
*/
-#pragma once
-
-/// \file iceberg/resolving_file_io_internal.h
-/// \brief Internal helpers for ResolvingFileIO. Not part of the public API.
-
-#include <string_view>
-
-#include "iceberg/iceberg_export.h"
-#include "iceberg/result.h"
+#include "iceberg/util/location_util.h"
namespace iceberg {
-/// \brief The FileIORegistry name of the implementation serving `location`,
-/// chosen by its URI scheme. Exported so tests can link it in shared builds.
-ICEBERG_EXPORT Result<std::string_view> ResolveFileIOName(std::string_view
location);
+std::string_view LocationUtil::ParseScheme(std::string_view location) {
+ const auto colon = location.find(':');
Review Comment:
Should we find `://` here? Since Windows local path can contain `:`, not
sure if we should care much about Windows platform though :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
