twmb commented on PR #1843:
URL: https://github.com/apache/iceberg-go/pull/1843#issuecomment-5319052353
@zeroshade apologies — I rebased this onto `28b989e` and force-pushed, which
wiped your merge of main. That wasn't deliberate; I'd fetched upstream but not
this branch, so I didn't see your commit until after the push. CONTRIBUTING is
clear about not force-pushing and I should have looked first.
Nothing of yours is lost in content — the branch is the same four-file
change on top of current main. The reason I rebased rather than merging is that
your merge predates `28b989e` ("hotfix: remove redundant loop variable copy in
test"), so lint was still failing on `copyloopvar` in
`table/positional_delete_index_test.go`, a file this PR doesn't touch. Rebasing
onto that hotfix clears it.
Happy to restore your merge commit and stack a merge of main on top instead
if you'd prefer the history that way — just say so. I won't force-push this
branch again either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
