rdblue commented on code in PR #17198:
URL: https://github.com/apache/iceberg/pull/17198#discussion_r3798333949
##########
format/spec.md:
##########
@@ -674,11 +674,13 @@ A manifest file must store the partition spec and other
metadata as properties i
| _optional_ | _required_ | `format-version` | Table format version
number of the manifest as a string
|
| | _required_ | `content` | Type of content files
tracked by the manifest: "data" or "deletes"
|
-The schema of a manifest file is defined by the `manifest_entry` struct,
described in the following section.
+#### Content file uniqueness
+
+Within a snapshot, each content file must be referenced by at most one
manifest entry across all manifests; otherwise, the snapshot has undefined
behavior. Writers are not required to validate uniqueness at commit time.
Review Comment:
We have cases where we know that the reference implementation will produce a
DELETED and ADDED pair, right? I don't think we can say that you can't do that
if it has been valid and had defined behavior until now.
We can say writers _should not_ produce data like this, but saying it has
undefined behavior and can be rejected by readers could cause implementations
to break on existing tables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
