szehon-ho commented on code in PR #17521:
URL: https://github.com/apache/iceberg/pull/17521#discussion_r3799210009
##########
core/src/test/java/org/apache/iceberg/TestRewriteTablePathUtil.java:
##########
@@ -197,6 +197,47 @@ public void testNewPathBackupRestore() {
.isEqualTo("/table");
}
+ @Test
+ public void testReplacePathsTreatsPrefixAsLiteral() {
Review Comment:
Optional nit: this bundles two scenarios, and the first assertion passes
with or without the fix - the `.` matches itself, so `replaceFirst` produced
the correct target here too. Only the `warehouseXdb` half is the actual
regression guard. Splitting them would make it obvious which assertion is
load-bearing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
