ebyhr commented on code in PR #3808:
URL: https://github.com/apache/iceberg-python/pull/3808#discussion_r3801916103
##########
tests/avro/test_decoder.py:
##########
@@ -160,6 +160,23 @@ def test_read_double(decoder_class: Callable[[bytes],
BinaryDecoder]) -> None:
assert decoder.read_double() == 19.25
[email protected]("decoder_class", AVAILABLE_DECODERS)
[email protected](
+ "value",
+ [
+ 3.141592653589793,
+ 429496729622.314,
+ 0.1,
+ 1.0000000000000002, # smallest double above 1.0
+ 1e308, # overflows to inf in single precision
+ 5e-324, # underflows to 0.0 in single precision
+ ],
+)
+def test_read_double_keeps_full_precision(decoder_class: Callable[[bytes],
BinaryDecoder], value: float) -> None:
Review Comment:
I don't think this is a valid regression test. It passes even if we revert
`decoder_fast.pyx`'s change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
