wombatu-kun commented on PR #16910: URL: https://github.com/apache/iceberg/pull/16910#issuecomment-5325338491
> I think we should avoid adding new apis, and I think we can do so here by just changing the rewriteManifestList and nothing else. > > Ideally I think we would want to change RewriteResult so that we can keep the methods as they are, the revapi breaks from disrupting the existing APIs are I think warranted because they basically cannot be used correctly as is. c0337bea8 takes that shape. Since the old signature is gone, the fix is back in all three Spark trees rather than 4.1 alone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
