u70b3 commented on PR #17028: URL: https://github.com/apache/iceberg/pull/17028#issuecomment-5328235067
@pvary Rebased onto latest main now that #17696 has merged. As you suggested, the changes touching the removed deprecated classes (`BaseFileWriterFactory`, `GenericAppenderFactory`) are gone — the PR is reduced to the validation still needed by the remaining paths (14 → 11 files): `DeleteSchemaUtil.validateEqualityFieldIds` plus call sites in `FileWriterBuilderImpl`, the Avro/ORC/Parquet delete-write builders, and `RegistryBasedFileWriterFactory`. Verified locally: new tests pass across core/data/orc/parquet and spotless is clean. Could you take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
