kevinjqliu commented on PR #3780: URL: https://github.com/apache/iceberg-python/pull/3780#issuecomment-5335644230
We should not merge this as-is. Please rebase onto current `main`: #3320 already fixed #3758 by preserving the row predicate during copy-on-write. More importantly, replacing `delete_by_predicate()` with a `partition_filters`-only update leaves `_predicate == AlwaysFalse()` for direct `delete_data_file()` overwrites. On a commit retry, concurrent data-file deletion validation is then skipped. I reproduced a delete/replacement race that `main` rejects with `ValidationException`, while this PR retries and commits, resurrecting deleted data. The fix should keep partition-space pruning, restore exact deleted-file validation, and add direct #3779 plus concurrent retry tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
