plusplusjiajia commented on PR #2960: URL: https://github.com/apache/iceberg-rust/pull/2960#issuecomment-5336755160
> Do we really need this? The sessionContext will be fully controlled by users, and they can set them in `credentials` if they want to keep them redacted Fair question — credentials didn't exist when I opened this (it came with #2971), and with it there, redacting by key name is largely redundant. What it doesn't cover is a secret embedded in a value that is legitimately a property: the SQL catalog's uri is postgres://user:pass@host/db, and SessionContext still derives Debug. Happy to cut this down to just that case, or close it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
