plusplusjiajia commented on PR #2332: URL: https://github.com/apache/iceberg-rust/pull/2332#issuecomment-5357573506
@CTTY @Xuanwo Sorry to ping again — I'd rather check the reasoning than push another revision. The dual path tries to satisfy both points at once: oss:// goes through S3 only when s3.* config is present, so native RAM/OIDC still works when it isn't (@Xuanwo), and it's feature-gated so S3-only builds pull in no OSS code (@CTTY). The cost I've found since: one props map serves every scheme, so a config carrying both s3.* and oss.* is ambiguous — pyiceberg and Java avoid that by routing oss:// through S3 unconditionally. Does that tradeoff still look right, or would you rather collapse it to a single path? Happy to implement either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
