dramaticlly opened a new pull request, #17751: URL: https://github.com/apache/iceberg/pull/17751
Follow up of https://github.com/apache/iceberg/pull/17638#issuecomment-5350304623 with changes in `PlanTableScanResponse.Builder` and `FetchPlanningResultResponse.Builder` 1. `withCredentials(List<Credential>)` now replaces the builder's credentials instead of appending to them. 1. It now rejects a `null` list and `null` elements with `Preconditions.checkArgument` follow up of https://github.com/apache/iceberg/pull/14994#discussion_r2674976008 4. `build()` now passes `ImmutableList.copyOf(credentials)` instead of the builder's live `ArrayList`. --- **AI Disclosure** - Model: Claude Opus 5 - Platform/Tool: Claude Code - Human Oversight: reviewed - Prompt Summary: Investigate the `withCredentials` append-vs-replace question raised in review of #17638. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
